Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date-time-picker.js add Iraq and saudia an Kuwait local #15220

Closed
wants to merge 1 commit into from

Conversation

NazarAli
Copy link

@NazarAli NazarAli commented Jan 1, 2025

add local for iraq and saudia and kuwait and tunis

Description

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

add local for iraq and saudia and kuwait and tunis
@danharrin
Copy link
Member

Since these aren't available locales in Filament how will these locales be used?

@danharrin danharrin added the i18n label Jan 1, 2025
@danharrin danharrin added this to the v3 milestone Jan 1, 2025
@NazarAli
Copy link
Author

NazarAli commented Jan 1, 2025

it found in package dayjs

https://github.com/iamkun/dayjs/tree/dev/src/locale

@danharrin
Copy link
Member

I know, but how do you use it in Filament? If you set the locale to one of these, you will not have any of the other translations in the UI

@danharrin
Copy link
Member

Closing as I don't think this works since Filament does not have these locales as options in the main translation files

@danharrin danharrin closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants