Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TimePicker and time method with generate argument #15217

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

achyutkneupane
Copy link

@achyutkneupane achyutkneupane commented Dec 31, 2024

Description

When using --generate with php artisan make:filament-resource, it detects date, datetime, and timestamps but not time.
So, I added the time field and column generation.

Visual changes

The description seems clear but here is what it generates:

image image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@achyutkneupane achyutkneupane changed the title Time generate Added TimePicker and time method with generate argument Dec 31, 2024
@danharrin danharrin added this to the v4 milestone Jan 1, 2025
@danharrin danharrin merged commit 464b343 into filamentphp:4.x Jan 2, 2025
10 checks passed
@achyutkneupane achyutkneupane deleted the time-generate branch January 2, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants