Added TimePicker and time method with generate argument #15215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achyutkneupane
force-pushed
the
time-generate
branch
from
c7388e5 to
195366e
Compare
|
Hi, apologies but we are no longer accepting new features for v3 as per #13744. I would accept a PR for this feature when v4 is released, if you are still interested. Thank you! |
|
@danharrin This thing is missing in v4 too. How about a PR for this on v4? |
|
Yes I would accept a v4 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
--generatewithphp artisan make:filament-resource, it detectsdate,datetime, andtimestampsbut nottime.So, I added the time field and column generation.
Visual changes
The description seems clear but here is what it generates:
Functional changes
composer cscommand.