Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): incorrect heading margin #15187

Merged

Conversation

behollder
Copy link
Contributor

@behollder behollder commented Dec 27, 2024

Description

Related to PR #14993 and issue #14938
Fixed broken margin for centered heading in different cases.
Also increased a margin to 6 to make it look better.

Visual changes

Before

Screenshot 2024-12-27 at 05 02 12 Screenshot 2024-12-27 at 05 03 06

After

Screenshot 2024-12-27 at 05 06 10 Screenshot 2024-12-27 at 05 06 20

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added bug Something isn't working ui labels Dec 31, 2024
@danharrin danharrin added this to the v3 milestone Dec 31, 2024
@danharrin danharrin merged commit c46f512 into filamentphp:3.x Dec 31, 2024
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants