Fix inconsistent escaping behaviour #15124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please do this in v4? Technically it is a breaking change and while I think we should make it consistent, it could cause security issues for people who are expecting these to be escaped. As a workaround in v3 you might be able to pass an HtmlString() where you don't want these escaped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some inconsistency with regards to how attributes are escaped. In most places they are already not escaped, this PR prevents the escaping on the rest of the places in the framework where we are using
->merge().This solves issues where eg
->extraEntryWrapperAttributes([ 'class' => '[&_dt>span]:text-gray-500', ])is escaped and ends up as[&...]in the html.