Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table ui when all searchable colums hidden #15108

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

dododedodonl
Copy link
Contributor

Description

When using individually searchable columns, but not having any of these columns visible, results in an extra piece of unwanted UI. This fixes that.

Visual changes

Before

ff_before

After

ff_after

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@dododedodonl dododedodonl changed the title Fix table ui when all searchable colum hidden Fix table ui when all searchable colums hidden Dec 17, 2024
@danharrin danharrin added the bug Something isn't working label Dec 17, 2024
@danharrin danharrin added this to the v3 milestone Dec 17, 2024
@danharrin danharrin merged commit 090fc9e into filamentphp:3.x Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants