Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 07-advanced.md, document isAbsolute for $get #15098

Closed
wants to merge 1 commit into from

Conversation

Lockyc
Copy link

@Lockyc Lockyc commented Dec 16, 2024

Added missing documentation of $get function. Found the solution in #4843 by @danharrin

Description

I was having difficulty accessing property values which I was unable to resolve until I stumbled across @danharrin's solution. I had come across the isAbsolute property, but i did not realise it was the absolute path of the Livewire component.

I have added the information @danharrin provided with a code example in the appropriate section of the Advanced Forms page.

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

Added missing documentation of $get function. Found the solution in filamentphp#4843 by @danharrin
@danharrin danharrin added the documentation Improvements or additions to documentation label Dec 17, 2024
@danharrin danharrin added this to the v3 milestone Dec 17, 2024
@danharrin
Copy link
Member

Thanks! Going to keep this out of the documentation still though, as it's tricky to explain how to find the correct absolute path (do you choose data or mountedActionData or something else)? I think it might cause more confusion than it's worth, and I want to encourage users to use ../../ to traverse the state paths instead. Maybe it will get simpler in the future.

@danharrin danharrin closed this Dec 17, 2024
@Lockyc
Copy link
Author

Lockyc commented Dec 17, 2024

👍 ok no worries, I figured that might be the case.
I hoped it would just help the next person find the solution and figure it out with some troubleshooting.

I only found the ../../ traversal pattern after this pr.
Its documented in the Repeater documentation, not with the rest of the $get documentation.
I'm not sure it would have solved my problem anyway.

@Lockyc Lockyc deleted the patch-1 branch December 17, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants