Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle tag switching for non-ASCII characters #15065

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: handle tag switching for non-ASCII characters #15065

merged 1 commit into from
Dec 11, 2024
+3 −3

Conversation

zxc88645
Copy link
Contributor

Description

Fixed an issue where tabs or steps could not be switched when non-ASCII characters (e.g., Chinese) were used as their titles.

#14080

Visual changes

none

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Dec 11, 2024
@danharrin danharrin added this to the v3 milestone Dec 11, 2024
@danharrin danharrin merged commit acd69f1 into filamentphp:3.x Dec 11, 2024
1 check passed
@danharrin
Copy link
Member

Thanks for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@zxc88645 @danharrin