Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker is set to readOnly(), but it still can clicked and open calendar popup #15064

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

untillnesss
Copy link
Contributor

@untillnesss untillnesss commented Dec 11, 2024

Description

I'm using DatePicker with readOnly() and native(false) options, but I can still do the Click action and it displays the calendar popup.

Visual changes

No visual changes.

Functional changes

Just add IF if it isReadOnly.

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Dec 14, 2024
@danharrin danharrin added this to the v3 milestone Dec 14, 2024
@danharrin danharrin merged commit d9c7f5d into filamentphp:3.x Dec 14, 2024
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants