Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x-ignore from table/index.blade.php #15044

Closed
wants to merge 1 commit into from

Conversation

angus-mcritchie
Copy link

Fix for Livewire v3.5.13 bug that screen goes black after table action see discussion - #14901

Caution

I did test this on my own project, which has multiple tables, modals, filters, etc, and everything worked as expected. However, I don't know why the x-ignore attribute was there is the first place. So it would be great to get this tested by others.

Description

Fixes bug reported https://discord.com/channels/883083792112300104/956270111176679516/1311365505776488458 and https://discord.com/channels/883083792112300104/1313209203564871710/1313209203564871710

I think this bug was introduced by Livewire bumping the Alpine version containing this commit which prevents initialising components inside an x-ignore attribute.

You can view the original discussion here - #14901

Visual changes

Before: screen goes black (as 5 modal backdrops display).
After: no modal backdrops and you can use the panel as normal.

Functional changes

  • [x ] Code style has been fixed by running the composer cs command.
  • [x ] Changes have been tested to not break existing functionality.
  • [x ] Documentation is up-to-date.

Fix for Livewire v3.5.13 bug that screen goes black after table action see discussion - filamentphp#14901
@angus-mcritchie
Copy link
Author

I'd also like to note that this pull request's goal is to bump the livewire version again; I haven't updated the composer.json in this pull request.

@danharrin
Copy link
Member

Unfortunately we cannot do this, the attribute is there to support the Async Alpine lazy loaded component. I think that Alpine needs to revert this breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants