Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Heroicons for rich editor and Markdown editor #14878

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

zepfietje
Copy link
Member

@zepfietje zepfietje commented Nov 25, 2024

Description

Rich editor and Markdown editor toolbar buttons still used old Font Awesome icons that didn't fit the other default icons in Filament. In the meantime, Heroicons has released a bunch of new icons that were missing. This pull request updates the editor toolbar buttons to use those new icons.

Visual changes

Before

Screenshot 2024-11-25 at 11 19 17 Screenshot 2024-11-25 at 11 20 18

After

Screenshot 2024-11-25 at 11 19 24 Screenshot 2024-11-25 at 11 19 44

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@zepfietje zepfietje added enhancement New feature or request ui labels Nov 25, 2024
@zepfietje zepfietje added this to the v3 milestone Nov 25, 2024
@zepfietje zepfietje requested a review from danharrin November 25, 2024 10:22
@danharrin danharrin merged commit 9482da8 into 3.x Nov 27, 2024
20 checks passed
@danharrin danharrin deleted the use-heroicons-for-rich-editor-and-markdown-editor branch November 27, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants