Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have next and previous functions disabled when their actions are disabled in the Wizard component #14558

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

whoisnegrello
Copy link
Contributor

Description

It's a small fix to have the next and previous functions disabled when their actions are disabled in the Wizard component

Visual changes

image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please save the $previousAction and $nextAction into variables for reuse. Then wrap the x-on:click with an @if checking $previousAction->isDisabled() etc. Then you can remove the changes to the JavaScript.

@danharrin danharrin added the bug Something isn't working label Oct 21, 2024
@danharrin danharrin added this to the v3 milestone Oct 21, 2024
@danharrin danharrin merged commit 349aa8e into filamentphp:3.x Oct 22, 2024
10 checks passed
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants