Add option for using docker volume for data persistence #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current docs provide two types of using Fief in projects:
I think it will be useful to add
--use-docker-volume
option to quickstart command to provide complete command for local setup with persistence. Currently, the data is stored inside the container without using volumes, and while it technically will persist across container restart, using volume is more reliable way to persist data (e.g. across rebuilding Fief image).I believe persistence can be useful in local setup.
Docs improvements
If this PR will be accepted, the docs also should be edited to highlight this option. In fact, the docs now contain a bit of misleading information, as current setup doesn't persist data during container rebuilds:
Also, the default value for
DATABASE_LOCATION
in https://docs.fief.dev/self-hosting/environment-variables/ is stated is "Current working directory", while it's actually/data/db
for Docker setup