Open
Conversation
Owner
|
@staab please review |
|
I would personally have the relay generate the code and expiration policy rather than the requester. This is how https://github.com/nostr-protocol/nips/pull/1079/files works. But it's completely unspecified, so this approach is also fine. The code and expiration stuff should probably be optional, and possible for the relay to reject if they fall outside of certain boundaries. But the PR looks fine to me. |
Owner
|
Unconvincing review, I'll have to review it myself. |
|
found this while trying to figure out how invite codes work for nip-29 groups. lgtm, we should probably update the NIP-29 spec since as @staab mentions the invite codes are underspecified. |
…BasedOnGroupRules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statewith expiration supportkind 9021join requests