Joystick Crosshair now uses Crosshair Edge Boundary slider#678
Open
AL2009man wants to merge 5 commits intofgsfdsfgs:portfrom
Open
Joystick Crosshair now uses Crosshair Edge Boundary slider#678AL2009man wants to merge 5 commits intofgsfdsfgs:portfrom
AL2009man wants to merge 5 commits intofgsfdsfgs:portfrom
Conversation
This wasn't explained properly, but that slider was meant for Mouse Input, but now Joystick obtain the same benefit. But to ensure the migration remains smooth: the joystick boundary slider is slightly higher than Mouse inorder to maintain the same crosshair boundary as before (if set to 60%). In case you didn't noticed: `crosshairedgeboundary` default has been changged to `6` to match the same setup as the joystick's, while changing the slider to be a percentage instead of a simple "0 to 10"
to reduce bloat, the math portion has been centralized, while attempting to fix and match the original setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the introduction of Crosshair Edge Boundary (#631): Joystick is the only thing that is left out of the party. This was intentional as it was meant for Mouse Input, but this may cause confusion.
but now: Joystick's Crosshair uses the same Crosshair Edge Boundary setup, Joystick users now has extra amount space to aim before the camera moves.
perfectdarkjoystickcrosshairedge.mp4
To maintain consistency with the original
60hardcoded value, math had to be employed inorder to closely match, thus: the spacing is larger than Mouse and Gyro (soon) combined.Because of this:
crosshairedgeboundarydefault has been changed to6to match the same setup as the joystick's, while changing the slider to be0-100%percentage instead of a simple "0-10". The change to percentage was just as a just-in-case if a seasonal speed runner notice the joystick crosshair being slightly different but might wanna readjust it.