initial Controller Button Prompt detection support#640
Draft
AL2009man wants to merge 35 commits intofgsfdsfgs:portfrom
Draft
initial Controller Button Prompt detection support#640AL2009man wants to merge 35 commits intofgsfdsfgs:portfrom
AL2009man wants to merge 35 commits intofgsfdsfgs:portfrom
Conversation
for now: this only applies to Key Bindings menu
since this repository doesn't do Button Icons, the name has been changed to properly the text-based Button Prompt "icons".
Author
|
as of this writing: this is considered a "Draft PR", as additional testings will be needed for DualSense Edge and Nintendo Switch Joy-Con Pair in regards to "Paddle" button setups. note: i don't own these two controllers |
DualSense prompt accidentally uses Nintendo Switch prompts. This has be addressed.
instead of hardcoding (aside from Nintendo Switch's), there's now a standardization setup that can be used across all Controller Types if needed.
during the backporting process, the older names were brought over, but his has been fixed
added support for Steam hardware prompts, while attempting to fix the button icon layout ordering to be a bit more consistent with SDL2 GameController Button mappings.
it should now detect Steam Deck prompts via Steam Virtual Gamepad...i hope?
…9man/perfect_dark into ButtonPromptSupportInitial
for some reason: it's it own thing, we'll do one last ditch effort on fixing the detection issue once and for all.
Author
|
Just added Steam Deck and Steam Controller prompts, but right now: we're testing Steam Virtual Gamepad detection usage to ensure that Deck's Game Mode plays nicely. this might take sometime to get it working properly while playing nicely with various Controller Types. |
This reverts commit 866480e.
added optional glyph support for N64 Controller, although: the mappings are based upon Nintendo Switch Online variant. due to that: actual mappings are using Nintendo Switch Pro Controller's protocol as a basis.
moved PID/VID over to glyph.h for easier organization
…tection` this is one final experiment before we drop stick with Steam Virtual Gamepad PID
it's clear that Steam Virtual Gamepad is the highest priority. for now: we're restoring the original function
the Left/Right Joy-Con glyphs has been corrected
AL2009man
changed the title
AL2009man
changed the title
Author
|
I forgot to mention this, Nintendo 64 button prompts are added in, but it'll be based on the NSO Nintendo 64 model, which means the actual placement will derive from Switch Pro Controller protocol. GameCube button prompts will not be planned for the time being, at least until SDL3 migration (easier to support Nintendo GameCube controllers) |
temporarily switch to Generic Prompts on Steam Deck's under Game Mode.
This reverts commit dbcdb0d.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently: the Button "icons" are based on
vkJoyNames, however: it's based upon a DirectInput-style system beyond the "Xbox naming scheme". a DualSense Edge or Nintendo Switch Joy-Con user might not understand what "JOY1_BUTTON_17" really means.In wake of SInput HID Protocol support (SDL3 only or SDL_GameControllerDB): it's a good time to revise the whole setup, while preparing for SDL3's
SDL_GetGamepadButtonLabel.within Extended Controller Settings, Each player can now select which Button Icons to choose from:
SDL_GameControllerGetTypeand Steam Virtual Gamepad VID/PID)screenshot represents WIP build, not represented of the finalized version
This does not affect the internal Button Remapping system, this is to ensure backwards compatibility with
pd.iniconfig files, however: for those who prefer the originalvkJoyNamesname: you can select "Internal" and it'll be used.As of this writing: this only applies to Key Bindings, in-game prompt UI will still use baked-in N64 prompts for the time being. This is a huge undertaking, and it'll require a completely separate PR (without conflicting with #624). This PR only serves as a foundation.