Allow users to set up more than one Laptop Gun sentry#446
Allow users to set up more than one Laptop Gun sentry#446blaiz wants to merge 1 commit intofgsfdsfgs:portfrom
Conversation
| struct autogunobj *g_ThrownLaptops = NULL; | ||
| struct beam *g_ThrownLaptopBeams = NULL; | ||
| s32 g_MaxThrownLaptops = 0; | ||
| s32 g_MaxThrownLaptopsPerPlayer = 1000; |
There was a problem hiding this comment.
Each user can now set up up to 1000 sentry guns
| setupLoadModeldef(modelnum); | ||
| modeldef = g_ModelStates[modelnum].modeldef; | ||
| laptop = &g_ThrownLaptops[index]; | ||
| s32 laptopIndex = index * g_MaxThrownLaptopsPerPlayer; |
There was a problem hiding this comment.
This is when the user sets up a new sentry. All sentries are stored in one big array, so now that each player can have multiple, let's multiply the player index with the number of sentries per player to find the start of the searching space. Then let's iterate over the space allocated for that user until we find a free space to store that new sentry gun in memory.
|
To be honest, I think 10 is more than sufficient. :P |
|
You haven't met my kid 😀 |
I still feel like there should be a limiter option for this lol. |
|
Someone tell me when this is added to a new stable, this has my interest. :) |
Would that remain true if it was limited to anything under 4? The number of laptops being limited to say, only 3? How many laptops could you have the limit be at and still have crashes but very rare like the stable. 20? 10? less than 10? Curious |
|
That's a good question. It would require enough testing to convince the maintainer that it can be merged into the port branch. In the meantime I'd recommend building your own copy of the game. Let me know if you need help doing that. |
Your build is too far back, its like 300 commits behind. Also, I think 1000 is a bit nuts personally. That is asking for crashes lol. I am not into 1000, maybe like at most 10? Just sayin... I think trying for a lower number than 11 like 10 or less, would make it less crash prone. Just a guess but 1000 sounds too damn crazy. Actually, make it 5 and an optional experimental setting that can be turned on in advanced with a "could be buggy" warning next to it |
|
What I mean is you can clone the current repo here locally, create a new branch, git cherry-pick 13a415a from my repo, tweak it to be 10 instead of 1000 and you're good to go. And yes 1000 is crazy, 10 is more reasonable. There's probably a way to put this behind a setting in the Extended menu, even potentially make it dynamic and controllable in the UI or something but I don't have the expertise nor the time to do that at the moment. Maybe someday. |
Recommendation for commands to run? Just asking, because I don't know how I would do this. |
2 participants
Here's a draft PR to allows users to set up up to 1000 sentry guns instead of just one. This can be fun in multiplayer, where you can have a level covered with sentries everywhere.
This is a draft PR just to gauge interest. If this is something we'd want, this would likely need to be a setting somewhere, or potentially a cheat. I'm not sure how that would work since the game allocates memory for a certain number of sentries, so I don't know how to make that dynamic yet but I can spend a bit of time and figure that out if there's interest.
As it currently is, this game works well most of the time but the game does crash sometimes.