fix(pkey): use EVP_PKEY_fromdata to load JWK #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 9 changed files in this pull request and generated 2 comments.
Files not reviewed (8)
- lib/resty/openssl/auxiliary/jwk.lua: Language not supported
- lib/resty/openssl/include/evp.lua: Language not supported
- lib/resty/openssl/include/evp/pkey.lua: Language not supported
- lib/resty/openssl/param.lua: Language not supported
- lib/resty/openssl/pkey.lua: Language not supported
- lib/resty/openssl/version.lua: Language not supported
- t/openssl/aux/jwk.t: Language not supported
- t/openssl/pkey.t: Language not supported
fffonion
force-pushed
the
evp-pkey-fromdata
branch
4 times, most recently
from
c726bac to
283184b
Compare
This fixes the key not able to be called get/set_params later
fffonion
force-pushed
the
evp-pkey-fromdata
branch
from
283184b to
8dead74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the key not able to be called get/set_params later.
Also feat(pkey) add pkey:get_size and allow only return NID of key type