[CI/CD] CI/CD 전략 변경 #5

taek2222 · 2025-11-27T10:43:08Z

#️⃣ 이슈 번호

#2

🛠️ 작업 내용

CI/CD 전략을 변경했습니다.
Dev, Prod CodeDeploy 환경으로 변경했습니다.

🙇🏻 중점 리뷰 요청

각 삭제한 파일이랑 이름 잘 확인해 주세요!
잘못되게 적용된 부분이 있는 지 검토해주세요!

coderabbitai · 2025-11-27T10:43:15Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)

android
backend
frontend

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Note

`.coderabbit.yaml` has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'tools'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ci-cd/2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This pull request migrates the CI/CD strategy from a self-hosted runner approach to AWS CodeDeploy for both development and production environments.

Key Changes:

Replaced self-hosted runner deployment with AWS CodeDeploy using S3 artifact storage
Introduced new deployment lifecycle scripts (stop, clean, start, validate) for CodeDeploy hooks
Added Slack notification workflows for PR events (opened, review requested, review submitted)

Reviewed changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`src/main/java/com/daedan/festabook/global/config/CloudWatchMetricsConfig.java`	Removed CloudWatch metrics configuration (no longer needed)
`infra/appspec.yml`	Updated for CodeDeploy with proper lifecycle hooks and script locations
`infra/validate.sh`	New health check script for deployment validation
`infra/stop.sh`	New script to gracefully stop running application
`infra/start.sh`	Refactored to improve error handling and readability
`infra/clean.sh`	New script to clean old JAR files before deployment
`.github/workflows/ci.yml`	Renamed from "Backend CI Test" to "CI Test"
`.github/workflows/ci-cd-dev.yml`	New workflow for dev environment using CodeDeploy
`.github/workflows/ci-cd-prod.yml`	New workflow for prod environment using CodeDeploy
`.github/workflows/slack-notify-*.yml`	New workflows for Slack notifications on PR events
`.github/workflows/backend-cd-dev.yml`	Removed old self-hosted runner deployment workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/ci-cd-dev.yml

infra/start.sh

infra/clean.sh

.github/workflows/ci-cd-prod.yml

infra/validate.sh

infra/stop.sh

infra/appspec.yml

infra/validate.sh

Copilot · 2025-11-27T10:46:36Z

infra/stop.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+
+PID=$(pgrep -f festabook-0.0.1-SNAPSHOT.jar)


The pgrep command searches for festabook-0.0.1-SNAPSHOT.jar, which is a hardcoded version-specific jar name. This will break when the version changes (e.g., to 0.0.2-SNAPSHOT or 1.0.0).

Consider using a more flexible pattern:

PID=$(pgrep -f "festabook.*\.jar")

This will match any version of the festabook jar file.

Suggested change

PID=$(pgrep -f festabook-0.0.1-SNAPSHOT.jar)

PID=$(pgrep -f "festabook.*\.jar")

infra/start.sh

changuii · 2025-11-27T11:00:07Z

.github/workflows/ci-cd-prod.yml

+      - name: Upload artifact to S3
+        run: |
+          aws s3 cp "${{ steps.bundle.outputs.zip_path }}" \
+            "s3://${{ env.S3_BUCKET }}/prod/builds/${{ steps.bundle.outputs.zip_name }}"


S3 버킷이 우리 secret에 많아서, 내부용 혹은 배포용 버킷이라고 명명 짓는건 어떤가요?

좋은데요?! 바꾸겠습니다. ARTIFACT_BUCKET 바꾸겠습니다.

.github/workflows/ci-cd-prod.yml

soeun2537 · 2025-11-29T07:19:47Z

.github/workflows/ci-cd-prod.yml

+      id-token: write
+
+    env:
+      AWS_REGION: ap-northeast-2


으어 이거 리전도 가려야 하는 값 아닌가요?

리전도 함께 Secret 처리 하겠습니다. 👍

changuii

브랜치 바꿔주세요 !

changuii · 2025-11-29T16:30:33Z

.github/workflows/ci-cd-dev.yml

+
+on:
+  push:
+    branches: [ ci-cd/2 ]


브랜치가 잘못되었습니다.

changuii · 2025-11-29T16:32:19Z

.github/workflows/ci-cd-prod.yml

+
+on:
+  push:
+    branches: [ ci-cd/2 ]


브랜치 바꿔주세요

changuii · 2025-11-29T16:32:54Z

.github/workflows/ci.yml

@@ -1,4 +1,4 @@
-name: Backend CI Test
+name: CI Test


브랜치 변경해야합니다.

eoehd1ek

코멘트 확인해주세요~

eoehd1ek · 2025-12-01T10:52:23Z

.github/workflows/ci-cd-dev.yml

+
+on:
+  push:
+    branches: [ ci-cd/2 ]


브랜치 dev로 변경해야 해요.

eoehd1ek · 2025-12-01T11:02:45Z

.github/workflows/ci-cd-prod.yml

+
+on:
+  push:
+    branches: [ ci-cd/2 ]


브랜치 이름 prod로 변경해야 합니다.

eoehd1ek · 2025-12-01T11:03:42Z

.github/workflows/ci-cd-prod.yml

+        with:
+          aws-region: ${{ env.AWS_REGION }}
+          role-to-assume: ${{ secrets.AWS_OIDC_ROLE_ARN }}
+          role-session-name: festabook-ci-cd


role-session-name에 dev, prod를 구별할 수 있는 이름을 사용하는 건 어떤가요?

저도 이 부분에 대해서 고민을 해봤는데, dev prod 두 방향에서 구분할 필요성이 있다면 하려고 했습니다.

다만, 두 권한이 모두 일치해서 하나의 OIDC만 만들었는데 후유는 어떻게 생각해요?

어느 배포 작업에서 권한을 부여했는지 별칭을 나타내는 것으로 생각하고 role-session-name에 dev, prod를 구별하자는 코멘트 남겼어요.

어떤 상황에서 role-session-name을 확인할지 떠오르지 않네요.
비타 의견대로 추후 구별을 해야 하는 상황이 온다면 그 때 prod, dev 별칭을 나눠도 될 것 같아요.

infra/stop.sh

eoehd1ek · 2025-12-01T11:30:26Z

infra/stop.sh

+if [ -z "$PID" ]; then
+  echo "> No running application found"
+else
+  echo "> Killing process $PID"
+  kill -15 $PID
+  sleep 5
+fi


java를 sudo 권한으로 실행했으므로 kill 명령어 또한 sudo로 실행해야 합니다.

sleep 5로 5초를 전부 기다리는 것 보다 ps로 해당 프로세스가 종료되었는지 확인하는 게 더 안정적입니다.

# 1. 종료할 프로세스의 PID를 찾기 PID=$(pgrep -f "festabook.*\.jar") if [ -z "$PID" ]; then echo "> No running application found" else echo "> Killing process $PID" # java를 sudo로 실행했기 때문에 kill 명령어도 sudo를 써야 합니다. sudo kill -15 $PID # sleep 5 대신 PID 종료 확인 방식으로 작성한 스크립트 TIMEOUT=30 COUNT=0 # 3. 종료될 때까지 대기 루프 while [ $COUNT -lt $TIMEOUT ]; do # 해당 PID를 가진 프로세스가 존재하는지 확인 # ps -p $PID > /dev/null 2>&1 명령은 PID가 있으면 종료 코드 0, 없으면 0이 아닌 값을 반환 if ps -p $PID > /dev/null 2>&1; then echo "> 종료 대기 중... ($COUNT초 경과)" sleep 1 COUNT=$((COUNT + 1)) else echo "> 프로세스($PID)가 정상적으로 종료되었습니다." break fi done # 4. 타임아웃 시 강제 종료 (SIGKILL) if ps -p $PID > /dev/null 2>&1; then echo "> 경고: $TIMEOUT초 안에 프로세스($PID)가 종료되지 않았습니다." echo "> 강제 종료(SIGKILL -9)를 진행합니다." sudo kill -9 $PID else echo "> 이전 애플리케이션 정리 완료." fi fi

주신 코드로 변경 완료했습니다! 감사합니다.

infra/validate.sh

taek2222

추가적으로 작업한 내용에 대해서 전달 코멘트 남겼습니다.

taek2222 · 2025-12-02T12:00:38Z

src/main/java/com/daedan/festabook/global/config/S3ClientConfig.java

배포를 위해 변경한 파일입니다. 다른 PR 내용과 동일해 겹치지 않을 걸로 예상됩니다.

taek2222 · 2025-12-02T12:00:43Z

src/main/java/com/daedan/festabook/storage/infrastructure/LocalStorageManager.java

배포를 위해 변경한 파일입니다. 다른 PR 내용과 동일해 겹치지 않을 걸로 예상됩니다.

taek2222 · 2025-12-02T12:00:46Z

src/main/java/com/daedan/festabook/storage/infrastructure/S3StorageManager.java

배포를 위해 변경한 파일입니다. 다른 PR 내용과 동일해 겹치지 않을 걸로 예상됩니다.

changuii

LGTM

eoehd1ek · 2025-12-03T12:34:23Z

.github/workflows/ci-cd-prod.yml

+        with:
+          aws-region: ${{ env.AWS_REGION }}
+          role-to-assume: ${{ secrets.AWS_OIDC_ROLE_ARN }}
+          role-session-name: festabook-ci-cd


어느 배포 작업에서 권한을 부여했는지 별칭을 나타내는 것으로 생각하고 role-session-name에 dev, prod를 구별하자는 코멘트 남겼어요.

어떤 상황에서 role-session-name을 확인할지 떠오르지 않네요.
비타 의견대로 추후 구별을 해야 하는 상황이 온다면 그 때 prod, dev 별칭을 나눠도 될 것 같아요.

taek2222 added 17 commits November 26, 2025 22:02

chore: CI/CD 스크립트 초안 작성

b84ae5c

chore: 쓰기 권한 추가

0d3f0c2

chore: 버킷 이름 수정

a842c21

chore: 주석 삭제 및 캐시 적용

830e423

chore: CodeDeploy 요청 적용

7952741

chore: CodeDeploy 설정 변경 삭제

46bcf62

chore: appspec 경로 수정

674848a

chore: 실행, 검증, 시작 스크립트 변경

6fce1e8

refactor: CloudWatchMetricsConfig 수정

31c31a7

refactor: start 스크립트 수정

be8cf8f

chore: 헬스 체크 시간 2분 증가

e4ddd1e

chore: clean, stop 트리거 추가

b7c2f5a

chore: 권한 root, 이름 변경

7c76efd

chore: clean 이름 변경

237583f

chore: 파일 이름 변경

46c831b

chore: 최종 dev prod CI/CD 생성

0fc0529

chore: 이름 간소화

26bb79e

taek2222 requested review from changuii, Copilot, eoehd1ek and soeun2537 November 27, 2025 10:43

taek2222 self-assigned this Nov 27, 2025

taek2222 added the CI/CD label Nov 27, 2025

Copilot started reviewing on behalf of taek2222 November 27, 2025 10:43 View session

Copilot finished reviewing on behalf of taek2222 November 27, 2025 10:45

Copilot AI reviewed Nov 27, 2025

View reviewed changes

changuii approved these changes Nov 27, 2025

View reviewed changes

taek2222 requested a review from changuii November 27, 2025 13:20

chore: ci-cd 버킷 시크릿 이름 변경

0d899f0

chore: 환경 변수 명확한 네이밍 수정

35c5ea7

soeun2537 approved these changes Nov 29, 2025

View reviewed changes

chore: Dev 서버 배포를 위한 브랜치 잠시 변경

5a66841

changuii approved these changes Nov 29, 2025

View reviewed changes

taek2222 added 5 commits November 29, 2025 17:30

chore: 잘못된 버킷 환경 변수 이름 수정

c1282b6

chore: Secrets 형태로 변경

1e5ba90

chore: start 스크립트 변경

5dd3cf3

chore: prod 브랜치 트리거 변경

2792b76

chore: Time out 시간 설정

f2af454

changuii requested changes Nov 29, 2025

View reviewed changes

eoehd1ek requested changes Dec 1, 2025

View reviewed changes

taek2222 added 3 commits December 2, 2025 00:51

refactor: 임시적 S3 변경

5d8550a

chore: prod 브랜치 트리거 재변경

103744e

refactor: 임시적 S3 Client Config 수정

69c66b2

taek2222 mentioned this pull request Dec 2, 2025

[Fix] Health Check API 변경시 CI-CD 스크립트 수정 #28

Closed

1 task

taek2222 added 3 commits December 2, 2025 20:55

chore: stop 스크립트 변경

8e23ed6

chore: 매개변수 secrets 변경

43a328c

chore: 매개변수 secrets 변경, 브랜치 수정

43b92f7

taek2222 requested review from changuii and eoehd1ek December 2, 2025 11:56

taek2222 added 2 commits December 2, 2025 20:57

chore: CI 스크립트 브랜치 변경

bc2dcc0

chore: release 브랜치 변경

b1d5faa

taek2222 commented Dec 2, 2025

View reviewed changes

changuii approved these changes Dec 2, 2025

View reviewed changes

chore: ci 디렉토리 변경

49bc789

eoehd1ek approved these changes Dec 3, 2025

View reviewed changes

taek2222 merged commit 9f27f1e into dev Dec 3, 2025
4 checks passed

taek2222 deleted the ci-cd/2 branch December 3, 2025 13:51

		@@ -0,0 +1,11 @@
		#!/bin/bash

		PID=$(pgrep -f festabook-0.0.1-SNAPSHOT.jar)

	PID=$(pgrep -f festabook-0.0.1-SNAPSHOT.jar)
	PID=$(pgrep -f "festabook.*\.jar")

[CI/CD] CI/CD 전략 변경 #5

[CI/CD] CI/CD 전략 변경 #5

Uh oh!

Conversation

taek2222 commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#️⃣ 이슈 번호

🛠️ 작업 내용

🙇🏻 중점 리뷰 요청

Uh oh!

coderabbitai bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

.coderabbit.yaml has unrecognized properties

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taek2222 Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

changuii left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eoehd1ek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

taek2222 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

taek2222 commented Nov 27, 2025 •

edited

Loading

coderabbitai bot commented Nov 27, 2025 •

edited

Loading

`.coderabbit.yaml` has unrecognized properties

taek2222 Nov 27, 2025 •

edited

Loading