-
Notifications
You must be signed in to change notification settings - Fork 0
[Refactor] 서버 튜닝 환경 반영 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR applies server tuning configurations by introducing a new Spring profile application-server.yml to optimize memory usage, particularly through JDBC driver cache size settings (250). The team decided to maintain Tomcat and Hikari configurations while focusing on JDBC driver optimizations to reduce GC and memory usage.
- Adds new "server" profile to Spring's active profiles
- Integrates the server configuration file creation in the build pipeline
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/resources/application.yml | Adds "server" to the included Spring profiles list to activate server tuning configurations |
| infra/buildspec.yml | Adds build step to decode and create application-server.yml from environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
infra/buildspec.yml
Outdated
| - echo "⚙️ [Pre Build Phase] 환경파일 생성 시작" | ||
| - mkdir -p src/main/resources/firebase | ||
| - echo "$SECRET_YML" | base64 -d > src/main/resources/application-secret.yml | ||
| - echo "$SEVER_YML" | base64 -d > src/main/resources/application-server.yml |
Copilot
AI
Dec 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variable name appears to have a typo: "SEVER_YML" should be "SERVER_YML". This will cause the build to fail as the environment variable won't be found, resulting in an empty application-server.yml file.
| - echo "$SEVER_YML" | base64 -d > src/main/resources/application-server.yml | |
| - echo "$SERVER_YML" | base64 -d > src/main/resources/application-server.yml |
|
|
|



#️⃣ 이슈 번호
🛠️ 작업 내용
서버 튜닝 환경 적용했습니다.
자료 조사 결과 메모리 차이만 발생해 아래 두 항목은 유지하기로 했습니다.
하지만, JDBC 드라이버 설정의 경우 250
CacheSize로 메모리 영향이 있기에 적용 후 GC 및 메모리 사용 빈도에 따라 소폭 감소할 예정입니다.Yml 설정 내용은 Notion 에서 확인 바랍니다.
🚨 PR 머지
🙇🏻 중점 리뷰 요청
application-server.yml명칭했는데, 더 좋은 네이밍 있으면 추천해주세요!