Skip to content

Conversation

@taek2222
Copy link
Contributor

@taek2222 taek2222 commented Dec 28, 2025

#️⃣ 이슈 번호

#47


🛠️ 작업 내용

서버 튜닝 환경 적용했습니다.

자료 조사 결과 메모리 차이만 발생해 아래 두 항목은 유지하기로 했습니다.

  • Tomcat
  • Hikari

하지만, JDBC 드라이버 설정의 경우 250 CacheSize 로 메모리 영향이 있기에 적용 후 GC 및 메모리 사용 빈도에 따라 소폭 감소할 예정입니다.

Yml 설정 내용은 Notion 에서 확인 바랍니다.

🚨 PR 머지

  • Merge 할 경우 GitHub Actions YML 추가해야함

🙇🏻 중점 리뷰 요청

  • Yml 네이밍이 application-server.yml 명칭했는데, 더 좋은 네이밍 있으면 추천해주세요!

@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • android
  • backend
  • frontend

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'tools'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/47

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies server tuning configurations by introducing a new Spring profile application-server.yml to optimize memory usage, particularly through JDBC driver cache size settings (250). The team decided to maintain Tomcat and Hikari configurations while focusing on JDBC driver optimizations to reduce GC and memory usage.

  • Adds new "server" profile to Spring's active profiles
  • Integrates the server configuration file creation in the build pipeline

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/main/resources/application.yml Adds "server" to the included Spring profiles list to activate server tuning configurations
infra/buildspec.yml Adds build step to decode and create application-server.yml from environment variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- echo "⚙️ [Pre Build Phase] 환경파일 생성 시작"
- mkdir -p src/main/resources/firebase
- echo "$SECRET_YML" | base64 -d > src/main/resources/application-secret.yml
- echo "$SEVER_YML" | base64 -d > src/main/resources/application-server.yml
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable name appears to have a typo: "SEVER_YML" should be "SERVER_YML". This will cause the build to fail as the environment variable won't be found, resulting in an empty application-server.yml file.

Suggested change
- echo "$SEVER_YML" | base64 -d > src/main/resources/application-server.yml
- echo "$SERVER_YML" | base64 -d > src/main/resources/application-server.yml

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

Overall Project 93.71% 🍏

There is no coverage information present for the Files changed

@taek2222 taek2222 self-assigned this Dec 28, 2025
@github-actions
Copy link

Overall Project 93.41% 🍏

There is no coverage information present for the Files changed

@sonarqubecloud
Copy link

@taek2222 taek2222 merged commit 84174eb into dev Dec 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants