[Feat] Grafana 모니터링 스택 설정 추가 #4

soeun2537 · 2025-11-27T04:48:02Z

#️⃣ 이슈 번호

#3

🛠️ 작업 내용

기존 CloudWatch 의존성 및 Config 제거
Grafana 모니터링에 필요한 설정 추가

🙇🏻 중점 리뷰 요청

특히 확인이 필요한 부분, 고민했던 부분 등을 적어주세요.

📸 이미지 첨부 (Optional)

coderabbitai · 2025-11-27T04:48:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)

android
backend
frontend

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

`.coderabbit.yaml` has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'tools'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

src/main/resources/application-monitoring.yml

eoehd1ek

템포 전송 url 주소 변경해야 합니다.

eoehd1ek · 2025-11-27T05:39:19Z

src/main/resources/application.yml

+
+management:
+  tracing:
+    sampling:
+      probability: 1.0


이 설정은 application-monitoring.yml에 똑같이 정의되어 있어요.
application.yml에 있는 부분은 지우는 게 좋을 것 같아요.

아 놓쳤네요 감사합니다!

promQL로 계산 가능한 p9X 계산 설정 삭제

eoehd1ek

application-secret.yml에 변경된 tempo 주소를 적용했습니다.
CD 스크립트 동작 전 업데이트 된 application-secret.yml을 적용해야 합니다.

changuii

LGTM

soeun2537 · 2025-12-26T07:05:30Z

추가 변경 사항

Log와 Trace AOP를 분리
공통 Pointcut 추출
Trace에 env 설정 추가

이후 해야할 업무

secret 업데이트
CD 스크립트 monitoring yml 추가

github-actions · 2025-12-26T07:07:31Z

Overall Project	93.41%	🍏

There is no coverage information present for the Files changed

changuii

확인해주세요!

src/main/java/com/daedan/festabook/global/logging/LoggingPointcuts.java

changuii · 2025-12-26T07:21:24Z

src/main/java/com/daedan/festabook/global/logging/TracingAspect.java

+    @Value("${env}")
+    private String env;


생성자로 주입받아서 final 붙이는건 어때요?

좋아요~ 바로 반영했습니다!

changuii · 2025-12-26T07:23:26Z

src/main/java/com/daedan/festabook/global/logging/TracingAspect.java

+    private String env;
+
+    @Around("com.daedan.festabook.global.logging.LoggingPointcuts.applicationLayers()")
+    public Object trace(ProceedingJoinPoint joinPoint) throws Throwable {


그 log에서 사용하는 traceId랑 trace에서 사용하는 traceId가 기존에 동일했는데 분리했을 때도 같은지 확인해봐야 할 것 같아요!

구두로 설명 드렸습니다! 같네요.

taek2222

코멘트 내용만 확인해 주세요!

src/main/resources/application-monitoring.yml

src/main/java/com/daedan/festabook/global/logging/LocalLoggingAspect.java

taek2222 · 2025-12-26T07:24:55Z

src/main/resources/logback-spring.xml

    <!-- DEV, PROD: JSON 형식으로 로그 파일 기록 -->
    <springProfile name="prod | dev">
-        <property name="LOG_FILE_PATH" value="/home/ubuntu/2025-festabook/spring-logs"/>
+        <property name="LOG_FILE_PATH" value="/var/log"/>


잘 기억이 나지 않아서, 이거 변경한 이유만 간단하게 남겨주세요! 인지하고 있을게요

후유 의견으로, 기존 경로는 환경 의존성이 강해서, 서버 자체 환경에서도 표준적으로 수집이가능한 /var/log로 통일했었던 기억이 있습니다.

github-actions · 2025-12-26T07:29:44Z

Overall Project	93.41%	🍏

There is no coverage information present for the Files changed

sonarqubecloud · 2025-12-26T07:29:47Z

Quality Gate passed

Issues
116 New issues
2 Accepted issues

Measures
0 Security Hotspots
82.8% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

changuii

LGTM

feat: Grafana 모니터링 스택 설정 추가

42d4ae6

soeun2537 requested review from changuii, eoehd1ek and taek2222 November 27, 2025 04:48

soeun2537 self-assigned this Nov 27, 2025

soeun2537 added the Feat label Nov 27, 2025

taek2222 requested changes Nov 27, 2025

View reviewed changes

src/main/resources/application-monitoring.yml Show resolved Hide resolved

feat: 공용 로그 폴더에 로그 남기도록 변경

c65e85f

taek2222 approved these changes Nov 27, 2025

View reviewed changes

eoehd1ek requested changes Nov 27, 2025

View reviewed changes

feat: application.yml 불필요 설정 제거

e4c14d8

soeun2537 requested a review from eoehd1ek November 29, 2025 07:18

eoehd1ek added 3 commits November 29, 2025 21:19

remove: tracing 불필요 설정 삭제

a9b81c4

promQL로 계산 가능한 p9X 계산 설정 삭제

refactor: 톰캣 메트릭 정보 설정 파일 위치 이동

0126650

refactor: 빈 줄 삭제

75fce15

eoehd1ek approved these changes Nov 29, 2025

View reviewed changes

changuii approved these changes Nov 29, 2025

View reviewed changes

soeun2537 added 2 commits December 26, 2025 16:02

feat: Log, Trace AOP 분리

dc4b157

feat: Alloy 설정 추가

34e9783

soeun2537 requested review from changuii and taek2222 December 26, 2025 07:05

changuii requested changes Dec 26, 2025

View reviewed changes

taek2222 reviewed Dec 26, 2025

View reviewed changes

refactor: 생성자 주입 방식으로 변경

da3c1a7

changuii approved these changes Dec 26, 2025

View reviewed changes

soeun2537 merged commit 4d1f216 into dev Dec 26, 2025
10 checks passed

soeun2537 deleted the feat/3 branch December 26, 2025 09:42

[Feat] Grafana 모니터링 스택 설정 추가 #4

[Feat] Grafana 모니터링 스택 설정 추가 #4

Uh oh!

Conversation

soeun2537 commented Nov 27, 2025

#️⃣ 이슈 번호

🛠️ 작업 내용

🙇🏻 중점 리뷰 요청

📸 이미지 첨부 (Optional)

Uh oh!

coderabbitai bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

.coderabbit.yaml has unrecognized properties

Uh oh!

Uh oh!

eoehd1ek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eoehd1ek left a comment

Choose a reason for hiding this comment

Uh oh!

changuii left a comment

Choose a reason for hiding this comment

Uh oh!

soeun2537 commented Dec 26, 2025

추가 변경 사항

이후 해야할 업무

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

changuii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taek2222 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

sonarqubecloud bot commented Dec 26, 2025

Quality Gate passed

Uh oh!

changuii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Nov 27, 2025 •

edited

Loading

`.coderabbit.yaml` has unrecognized properties