support less-commonly-used HTTP verbs: PUT, PATCH, DELETE #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it seems they're used by Ruby-on-Rails apps
![hikaflow[bot]](https://avatars.githubusercontent.com/in/1109659?s=60&v=4){kind=small}
| Response::builder() | ||
| .status(StatusCode::NO_CONTENT) | ||
| .header(header::ALLOW, "GET, POST, HEAD, OPTIONS") | ||
| .header( |
There was a problem hiding this comment.
Duplicate Code - Priority: High
This block of code is duplicated in ferron/src/request_handler.rs starting at line 805.
| _ => { | ||
| let mut header_map = HeaderMap::new(); | ||
| if let Ok(header_value) = HeaderValue::from_str("GET, POST, HEAD, OPTIONS") { | ||
| if let Ok(header_value) = |
There was a problem hiding this comment.
Duplicate Code - Priority: High
This block of code is duplicated in ferron/src/request_handler.rs starting at line 813.
PR SummaryChanges Overview
Identified Issues
Recommendations
|
|
I was thinking about security scanners... |
|
Yeah, depending on what host is receiving the verbs, that could indeeed be a security concern. So maybe less-common verb support needs to be configured per-host? |
|
Yes, I think that's a good idea to introduce a configuration option for allowing "PUT", "PATCH", and "DELETE" HTTP methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Ruby-on-Rails apps heavily use less-commonly-used HTTP verbs, so this patch adds support for them.
I'm not entirely sure if this is the right way to patch in support for new HTTP verbs in general, but it did work on my server. Let me know what you think. In my case, I only need the extra verbs for a reverse proxied host, and I think this patch is more general than that?