Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 6, 2025

Short description of the changes made

Adds support for a configurable rightText field in the logo configuration, allowing users to display text to the right of their logo image (similar to what Cohere currently uses, but now configurable via docs.yml).

Changes:

  • Added rightText: string | undefined to LogoConfiguration interface
  • Updated both withLogo.ts files to pass through logoRightText from config
  • Replaced the hardcoded Cohere domain check in layout.tsx with the config-driven approach
  • Added logoRightText to FDR API definition (read, write, db YAML files)
  • Added logoRightText to FDR SDK converters (using SDK types directly)

What was the motivation & context behind this PR?

This PR is part of a two-repo change to add a right-text field to the logo schema. The corresponding fern repo PR (fern-api/fern#11075) adds the schema definition, parsing logic, and wires the field into the FDR write request.

Note: The Cohere-specific hack (domain.includes("cohere") ? "Docs" : undefined) has been removed. Cohere will need to add right-text: Docs to their docs.yml configuration to maintain the current behavior.

Updates since last revision

  • SDK has been regenerated with logoRightText field
  • Removed all ExtendedDocsConfig, ExtendedWriteDocsConfig, and ExtendedDbDocsConfig type extensions
  • All code now uses SDK types directly (config.logoRightText, writeShape.config.logoRightText, dbShape.logoRightText)

How has this PR been tested?

  • Lint checks passed (pnpm lint:biome, pnpm lint:style)
  • TypeScript compilation verified locally

Human review checklist

  • Confirm the type cast in layout.tsx is acceptable: (config as { logoRightText?: string }).logoRightText
  • Confirm removal of Cohere hack is intentional (they'll need to update their config)
  • Verify FDR API definition changes (read, write, db YAML files) are correct

Link to Devin run: https://app.devin.ai/sessions/42df904f84f64b34a0696ddc33533983
Requested by: Catherine Deskur ([email protected])

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link
Contributor

vercel bot commented Dec 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dev.ferndocs.com Ready Ready Preview Dec 10, 2025 4:04pm
fern-dashboard Ready Ready Preview Dec 10, 2025 4:04pm
fern-dashboard-dev Ready Ready Preview Dec 10, 2025 4:04pm
prod-assets.ferndocs.com Ready Ready Preview Dec 10, 2025 4:04pm
prod.ferndocs.com Ready Ready Preview Dec 10, 2025 4:04pm
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
fern-platform Ignored Ignored Dec 10, 2025 4:04pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

🌱 Smoke Test Preview

Testing branch changes with smoke test content:

🕷️ Smoke Test Crawler Results

Pages crawled: 41
Successful: 41 ✅
With errors: 0

🎉 All pages loaded successfully with no errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants