-
Notifications
You must be signed in to change notification settings - Fork 26
feat(docs): add configurable logo right-text support #5714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: app
Are you sure you want to change the base?
Conversation
Co-Authored-By: Catherine Deskur <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🌱 Smoke Test PreviewTesting branch changes with smoke test content:
🕷️ Smoke Test Crawler ResultsPages crawled: 41 🎉 All pages loaded successfully with no errors! |
Co-Authored-By: Catherine Deskur <[email protected]>
…s regenerated Co-Authored-By: Catherine Deskur <[email protected]>
…text' into devin/1765045398-add-logo-right-text
…enerated Co-Authored-By: Catherine Deskur <[email protected]>
…go files Co-Authored-By: Catherine Deskur <[email protected]>
Short description of the changes made
Adds support for a configurable
rightTextfield in the logo configuration, allowing users to display text to the right of their logo image (similar to what Cohere currently uses, but now configurable via docs.yml).Changes:
rightText: string | undefinedtoLogoConfigurationinterfacewithLogo.tsfiles to pass throughlogoRightTextfrom configlayout.tsxwith the config-driven approachlogoRightTextto FDR API definition (read, write, db YAML files)logoRightTextto FDR SDK converters (using SDK types directly)What was the motivation & context behind this PR?
This PR is part of a two-repo change to add a
right-textfield to the logo schema. The corresponding fern repo PR (fern-api/fern#11075) adds the schema definition, parsing logic, and wires the field into the FDR write request.Note: The Cohere-specific hack (
domain.includes("cohere") ? "Docs" : undefined) has been removed. Cohere will need to addright-text: Docsto their docs.yml configuration to maintain the current behavior.Updates since last revision
logoRightTextfieldExtendedDocsConfig,ExtendedWriteDocsConfig, andExtendedDbDocsConfigtype extensionsconfig.logoRightText,writeShape.config.logoRightText,dbShape.logoRightText)How has this PR been tested?
pnpm lint:biome,pnpm lint:style)Human review checklist
layout.tsxis acceptable:(config as { logoRightText?: string }).logoRightTextLink to Devin run: https://app.devin.ai/sessions/42df904f84f64b34a0696ddc33533983
Requested by: Catherine Deskur ([email protected])