-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add code about hack and debug #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -402,6 +402,8 @@ impl ParquetReaderBuilder { | |
| let parquet_schema_desc = parquet_meta.file_metadata().schema_descr(); | ||
| let parquet_read_cols = read_format.parquet_read_columns(); | ||
| let leaf_indices = build_parquet_leaves_indices(parquet_schema_desc, &parquet_read_cols); | ||
| // TODO(fys): remove it later. | ||
| common_telemetry::info!("leaf_indices: {:?}", leaf_indices); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This adds an unconditional Useful? React with 👍 / 👎. |
||
| let projection_mask = | ||
| ProjectionMask::leaves(parquet_schema_desc, leaf_indices.iter().copied()); | ||
| let selection = self | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling
hack_scan_reqon everyscan_regionmutatesrequest.projection_inputfor all scans wheneverGREPTIME_PROJECTION_NESTED_PATHSis present, so one debug env setting can silently replace the planner-provided projection for unrelated queries. In that mode, the engine can return a different column set/schema than the query planned for, which can produce incorrect results or runtime schema-mismatch failures; this should be gated to explicit debug builds/paths instead of the default scan path.Useful? React with 👍 / 👎.