fix(build): fold typeof window in final builds - #29
Draft
fengmk2 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolldown
1.2.1received Oxc0.142.0through rolldown/rolldown#10497. That Oxc release includes oxc-project/oxc#24791, which preserves default-parameter side effects.The correct side-effect behavior exposes a native
definescope error. The transform can treat a body declaration such asvar windowas visible to a default parameter. It then keeps a browser-only dynamic import in a server build.This change runs the vinext scope-aware
typeof windowtransform in all production builds. It continues to use the native Vite define. It does not change the Vite+ version.The regression test checks the final-build transform with a default parameter and a body-local
var window.