Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #36 #37

Merged
merged 3 commits into from
Feb 27, 2017
Merged

Issue #36 #37

merged 3 commits into from
Feb 27, 2017

Conversation

kyletitus
Copy link
Contributor

#36

Added in simple retry logic to the get-weather.js file, this has a hardcoded max of 5 tries.
Added in simple caching via localstorage to the main coffeescript file.

I am mainly a back end guy, js/coffee are not languages I usually work in. Feel free to rip these changes apart. That being said, everything seems to be working on my machine locally.

Added in simple retry logic to the get-weather.js file, this has a hardcoded max of 5 tries.
Added in simple cachine via localstorage to the main coffeescript file.
@kevanchristmas
Copy link

Working fine for me so far - thanks for the effort!

@kyletitus
Copy link
Contributor Author

Made a quick update, was getting some stack traces when the widget tried refreshing after opening up my laptop from sleep. Just bad handling.

@felixhageloh
Copy link
Owner

Thanks again for the PR!
Unfortunately I need to discontinue this widget because I have absolutely no time to maintain it. Of course I will leave the code available and I will add any fork of this widget to the widget gallery again.
Would you by any chance be willing to take over this widget?

@kyletitus
Copy link
Contributor Author

I can take it over and at least keep it working as is. If anything happens that would cause a major overhaul (yahoo api breaking further) I most likely not be able to support it, but would at least give it the old college try.

@felixhageloh
Copy link
Owner

I think in this case I will just merge your PR for now - I don't want to push this on to you - and then ask around if anyone is interested in adopting this widget

@felixhageloh felixhageloh merged commit 6f9e43f into felixhageloh:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants