Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open_browser param to auth prompts #325

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

sventec
Copy link
Contributor

@sventec sventec commented Jun 22, 2024

This PR adds an open_browser parameter to both auth prompt functions. This is intended to behave similarly to the option in spotipy (ref 2), allowing for interactive auth without an attempt to open the system default browser.

This beneficial in some instances where opening the default browser could be abrupt to the user; I sometimes find manually pasting the link into my currently open browser helpful, as e.g. my system default browser is not open at the time, or I am using WSL, a VM, a container, etc. from which the relevant auth code is being invoked.

The open_browser param has a default value of True, so as to not modify the existing default behavior.

Related issue: None

  • Tests written with 100% coverage
    • N/A
  • Documentation and changelog entry written
  • All tox checks passed with an appropriately configured
    environment

@felix-hilden
Copy link
Owner

Beautiful 👌 could you write a changelog entry under a new "unreleased" header too?

@sventec
Copy link
Contributor Author

sventec commented Jun 26, 2024

@felix-hilden oops, thanks for the reminder. release notes have been updated!

@felix-hilden
Copy link
Owner

Thanks! This needs to run some live tests so the PR will fail, I'll try to merge it in in the coming days and run the tests for real 👍

@felix-hilden felix-hilden merged commit 737503c into felix-hilden:master Jul 4, 2024
4 of 6 checks passed
@sventec sventec deleted the feat-open-browser branch July 15, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants