Add open_browser param to auth prompts #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
open_browser
parameter to both auth prompt functions. This is intended to behave similarly to the option in spotipy (ref 2), allowing for interactive auth without an attempt to open the system default browser.This beneficial in some instances where opening the default browser could be abrupt to the user; I sometimes find manually pasting the link into my currently open browser helpful, as e.g. my system default browser is not open at the time, or I am using WSL, a VM, a container, etc. from which the relevant auth code is being invoked.
The
open_browser
param has a default value ofTrue
, so as to not modify the existing default behavior.Related issue: None
tox
checks passed with an appropriately configuredenvironment