Skip to content

Commit

Permalink
cosmos-sdk-proto: fixup TODO comments around Name trait (cosmos#436)
Browse files Browse the repository at this point in the history
  • Loading branch information
tony-iqlusion authored and Felipe Pimentel committed Dec 18, 2023
1 parent 96f1281 commit eb8aafe
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions cosmos-sdk-proto/src/type_names.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
//! Registry of type URLs associated with various protobuf types defined in
//! this crate.
//! Type name registry: used to compute type URLs.
// TODO(tarcieri): leverage first-class support for type URLs in prost?
// See: https://github.com/tokio-rs/prost/issues/299
// TODO(tarcieri): generate these automatically using `prost-build`
// See: https://github.com/tokio-rs/prost/issues/926

use crate::{cosmos, ibc, traits::Name};

Expand Down Expand Up @@ -500,8 +499,7 @@ mod wasm {
}
}

/// Workaround until tokio-rs/prost#923 is released
// TODO(tarcieri): remove this before final release
// TODO(tarcieri): remove this when tokio-rs/prost#923 is released (v0.12.1?)
fn full_name<T: Name>() -> String {
format!("{}.{}", T::PACKAGE, T::NAME)
}

0 comments on commit eb8aafe

Please sign in to comment.