Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cspell #1390

Merged
merged 3 commits into from
Aug 6, 2024
Merged

chore: add cspell #1390

merged 3 commits into from
Aug 6, 2024

Conversation

eseidel
Copy link
Contributor

@eseidel eseidel commented Aug 6, 2024

Add cspell dictionary and make it pass.

Originally I was just trying to fix spelling of "delimeter", but added
cspell as practice for myself and figured it might be useful to you.

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Add cspell dictionary and make it pass.

Originally I was just trying to fix spelling of "delimeter", but added
cspell as practice for myself and figured it might be useful to you.

- [ ] ✨ New feature (non-breaking change which adds functionality)
- [ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
- [X] 🧹 Code refactor
- [ ] ✅ Build configuration change
- [ ] 📝 Documentation
- [ ] 🗑️ Chore
@eseidel eseidel requested a review from felangel as a code owner August 6, 2024 16:27
@felangel felangel changed the title chore(mason_logger): v0.2.16 (#1377): Add cspell chore: add cspell Aug 6, 2024
@@ -5,6 +5,7 @@ import 'package:mason/mason.dart';

final hooksBundle = MasonBundle.fromJson(<String, dynamic>{
"files": [
// cspell:disable-next-line
Copy link
Owner

@felangel felangel Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// cspell:disable-next-line

I think we should likely avoid modifying the bundles and instead ignore them from cspell entirely since they are generated code.

@@ -5,6 +5,7 @@ import 'package:mason/mason.dart';

final greetingBundle = MasonBundle.fromJson(<String, dynamic>{
"files": [
// cspell:disable-next-line
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// cspell:disable-next-line

same here

@felangel felangel merged commit f3e4b38 into felangel:master Aug 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants