-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cspell
#1390
Merged
Merged
chore: add cspell
#1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cspell dictionary and make it pass. Originally I was just trying to fix spelling of "delimeter", but added cspell as practice for myself and figured it might be useful to you. - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🛠️ Bug fix (non-breaking change which fixes an issue) - [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change) - [X] 🧹 Code refactor - [ ] ✅ Build configuration change - [ ] 📝 Documentation - [ ] 🗑️ Chore
felangel
changed the title
chore(mason_logger): v0.2.16 (#1377): Add cspell
chore: add Aug 6, 2024
cspell
felangel
reviewed
Aug 6, 2024
@@ -5,6 +5,7 @@ import 'package:mason/mason.dart'; | |||
|
|||
final hooksBundle = MasonBundle.fromJson(<String, dynamic>{ | |||
"files": [ | |||
// cspell:disable-next-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// cspell:disable-next-line |
I think we should likely avoid modifying the bundles and instead ignore them from cspell entirely since they are generated code.
felangel
reviewed
Aug 6, 2024
@@ -5,6 +5,7 @@ import 'package:mason/mason.dart'; | |||
|
|||
final greetingBundle = MasonBundle.fromJson(<String, dynamic>{ | |||
"files": [ | |||
// cspell:disable-next-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// cspell:disable-next-line |
same here
felangel
reviewed
Aug 6, 2024
felangel
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cspell dictionary and make it pass.
Originally I was just trying to fix spelling of "delimeter", but added
cspell as practice for myself and figured it might be useful to you.