fix: create vendor tarball during propose_downstream#160
Open
pcdubs wants to merge 1 commit into
Open
Conversation
Member
|
create-archive does not run during release: https://packit.dev/docs/configuration/actions#syncing-the-release |
Add post-modifications action to create the vendor tarball and copy it to the downstream repository before Packit uploads to the lookaside cache. This ensures both Source0 and Source1 are available during propose_downstream. Follows the same pattern used by go-fdo-server and go-fdo-client. Signed-off-by: Paul Whalen <pwhalen@fedoraproject.org>
pcdubs
changed the title
Member
|
/test |
knecasov
reviewed
Jul 20, 2026
Comment on lines
+40
to
+45
| post-modifications: | ||
| # This runs during propose_downstream to prepare the vendor tarball for upload | ||
| - bash -c "cargo vendor vendor" | ||
| - bash -c "tar -cJf greenboot-rs-${PACKIT_PROJECT_VERSION}-vendor-patched.tar.xz vendor" | ||
| - bash -c "rm -rf vendor" | ||
| - bash -c 'if [ -n "${PACKIT_DOWNSTREAM_REPO}" ]; then cp greenboot-rs-${PACKIT_PROJECT_VERSION}-vendor-patched.tar.xz ${PACKIT_DOWNSTREAM_REPO}/; fi' |
There was a problem hiding this comment.
The reference implementations (go-fdo-client, go-fdo-server) use a single multi-line script with bash -xc — the -x flag gives you a trace of expanded commands in the Packit log, which makes debugging propose_downstream failures much easier. What do you think about the following modification, please?
post-modifications:
- |
bash -xc '
cargo vendor vendor
tar -cJf "greenboot-rs-${PACKIT_PROJECT_VERSION}-vendor-patched.tar.xz" vendor
rm -rf vendor
if [ -n "${PACKIT_DOWNSTREAM_REPO}" ]; then
cp "greenboot-rs-${PACKIT_PROJECT_VERSION}-vendor-patched.tar.xz" "${PACKIT_DOWNSTREAM_REPO}/"
fi
'
Note: I know that this pattern is not used in this file, but I still wanted to point it out.
Contributor
There was a problem hiding this comment.
The suggestion above is a nice-to-have for debuggability.
mcattamoredhat
approved these changes
Jul 20, 2026
Comment on lines
+40
to
+45
| post-modifications: | ||
| # This runs during propose_downstream to prepare the vendor tarball for upload | ||
| - bash -c "cargo vendor vendor" | ||
| - bash -c "tar -cJf greenboot-rs-${PACKIT_PROJECT_VERSION}-vendor-patched.tar.xz vendor" | ||
| - bash -c "rm -rf vendor" | ||
| - bash -c 'if [ -n "${PACKIT_DOWNSTREAM_REPO}" ]; then cp greenboot-rs-${PACKIT_PROJECT_VERSION}-vendor-patched.tar.xz ${PACKIT_DOWNSTREAM_REPO}/; fi' |
Contributor
There was a problem hiding this comment.
The suggestion above is a nice-to-have for debuggability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add post-modifications action to create the vendor tarball and copy it to
the downstream repository before Packit uploads to the lookaside cache.
This ensures both Source0 and Source1 are available during propose_downstream.
Follows the same pattern used by go-fdo-server and go-fdo-client.