chore: update fedimint to 0.8 - #73
Closed
elsirion wants to merge 1 commit into
Closed
Conversation
elsirion
commented
Jul 20, 2025
Comment on lines
-180
to
-189
| DbMigration { | ||
| index: 0, | ||
| sql: include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/schema/v0.sql")), | ||
| backfill: None, | ||
| }, | ||
| DbMigration { | ||
| index: 1, | ||
| sql: include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/schema/v1.sql")), | ||
| backfill: None, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
I need to combine these migrations into the latest supported one.
Collaborator
Author
There was a problem hiding this comment.
I guess we'll drop backfill support at some point and need to track that separately, but just keep all the pure SQL migrations so a new DB can be bootstrapped?
What would you say is the idiomatic way to remove legacy migrations while still maintaining the ability to set up a new DB @tacio @bradleystachurski?
Collaborator
Author
|
Superseded by #106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #72 since 0.8 is kinda stabilized already. @tacio can you check if there's any dependency unification problems with any forks you may maintain? If not I'll just merge.