-
-
Notifications
You must be signed in to change notification settings - Fork 85
Created fedify test-init CLI and fixed fedify init CLI with it
#479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the Fedify CLI by introducing a new Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new fedify test-init command, which provides a comprehensive testing framework for the fedify init command across various configurations. The init command itself has been significantly refactored for better modularity, dependency management, and error handling. The changes are well-structured and improve the robustness and maintainability of the CLI. I have one suggestion to remove some dead code for clarity.
|
The docs for this pull request have been published: |
|
Thanks for working on this PR! The Issue: Internal implementation details exposed in public APIThe
Suggested alternativesOption 1: Use environment variable instead // Check for test mode internally without a CLI flag
const isTestMode = Deno.env.get("FEDIFY_TEST_MODE") === "1";Then Option 2: Mark as internal command
Option 3: Move to development tasks // deno.json
{
"tasks": {
"test-init": "deno run -A packages/cli/src/init/test/mod.ts"
}
}This way it remains useful for contributors but doesn't pollute the public CLI interface. RecommendationI'd suggest Option 1 (environment variable) as it:
What do you think about this approach? |
05f6562 to
d7b22bc
Compare
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
|
Could you resolve conflicts? |
refactored related code
564a189 to
2649c9b
Compare
Summary
Created
fedify test-initCLI and fixedfedify initCLI with itRelated Issue
initCLI and fix the command #461Changes
packages/src/cli/initdocs/cli.mdBenefits
The
fedify test-initCLI was created to make it easy for contributors who want to extend thefedify initCLI to test their changes.Checklist
Did you write some tests for this change (if it's a new feature)?deno task test-allon your machine?Additional Notes
fedify test-initCLI was developed solely for use in local environments. CI/CD environments were not taken into consideration.fedify test-initCLI can't testbun,yarn,Next.jsfor now.The