Add @fedify/fresh package for Fresh 2.0 integration
#478
Conversation
Summary of ChangesHello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Fedify's compatibility by introducing a dedicated integration package for Fresh 2.0. This update ensures that developers can leverage Fedify's capabilities within the modern Fresh framework, complete with an example application and updated documentation to guide the transition from older Fresh versions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary of ChangesHello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Fedify's compatibility with the Fresh framework by introducing a dedicated integration package for Fresh 2.0. This update ensures that Fedify users can leverage the latest features and architecture of Fresh, providing a robust and future-proof solution for building federated applications on Deno. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new @fedify/fresh package for Fresh 2.0 integration, replacing the deprecated module for Fresh 1.x. The changes are well-structured, including the new package, a comprehensive example application, and updated documentation. The implementation of the Fresh middleware is clean and follows established patterns. I have one suggestion to improve the clarity of a code example in the documentation.
There was a problem hiding this comment.
Code Review
This pull request introduces a new @fedify/fresh package for seamless integration with Fresh 2.0, which is a great addition. The new package is well-structured, and the accompanying example application is comprehensive and very helpful for users to get started. The documentation is also updated to reflect these changes. My only suggestion is to make one of the documentation examples more complete to improve clarity for users. Overall, this is a solid contribution that aligns with Fresh's modern architecture.
Summary of ChangesHello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new package, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new @fedify/fresh package for seamless integration with Fresh 2.0, along with a comprehensive example application and updated documentation. The implementation of the Fresh middleware is clean and correctly utilizes Fresh 2.0's context and middleware patterns. The example project is well-structured and serves as a great starting point for users. I've made a few minor suggestions to improve documentation clarity, but overall, this is an excellent addition to the Fedify ecosystem.
issues-auto-labeler
bot
added
breaking change
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Apparently it fails to compile @fedify/cli into executables during the publish job in the CI… Could you change the packages/cli/scripts/pack.ts script so that it does not include node_modules directory at all?
diff --git a/packages/cli/scripts/pack.ts b/packages/cli/scripts/pack.ts
index e0270054..b4284c9d 100644
--- a/packages/cli/scripts/pack.ts
+++ b/packages/cli/scripts/pack.ts
@@ -26,7 +26,7 @@ async function compile(os: OS, arch: Arch, into: string): Promise<void> {
}
await $`deno compile --allow-all --include=${
join("src", "init", "templates")
- } --target=${target} --output=${into} ${
+ } --node-modules-dir=none --target=${target} --output=${into} ${
join(dirname(import.meta.dirname!), "src", "mod.ts")
}`;
}
|
@dodok8 Looks like there's a conflict with the |
|
The docs for this pull request have been published: |
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
|
I fixed the blank screen issue in commit 4cb9fda |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
2 participants
Summary
This PR introduces a new
@fedify/freshpackage that provides seamless integration between Fedify and Fresh 2.0, replacing the deprecated@fedify/fedify/x/freshmodule that was designed for Fresh 1.x.Related Issue
@fedify/freshpackage for Fresh 2.0 integration #466Changes
deno.json'snodeModulesDirfield toautofrom 'none`.Benefits
@fedify/fedify/x/freshmoduleChecklist
deno task test-allon your machine?Additional Notes
multicodecdependency, users must externalize @fedify/fedify in theirvite.config.ts(documented in the integration guide)