Skip to content

Add jiminy results using solana v2.2.6 and also binary sizes comparison#2

Merged
febo merged 15 commits intofebo:mainfrom
igneous-labs:feat/jiminy
May 2, 2025
Merged

Add jiminy results using solana v2.2.6 and also binary sizes comparison#2
febo merged 15 commits intofebo:mainfrom
igneous-labs:feat/jiminy

Conversation

@billythedummy
Copy link
Copy Markdown
Contributor

Probably wanna merge #1 first.

Add results for jiminy

@billythedummy billythedummy changed the title Add jiminy results using solana v2.2.6 Add jiminy results using solana v2.2.6 and also binary sizes comparison Apr 14, 2025
Copy link
Copy Markdown
Owner

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@billythedummy I think we need a rebase before merging.

@febo febo mentioned this pull request Apr 29, 2025
@febo
Copy link
Copy Markdown
Owner

febo commented Apr 29, 2025

@billythedummy Thanks for the PR. One thing that it clearly showed is that the CPI clients for pinocchio are not that efficient, and more surprisingly, they increase the binary size significantly. I have ditched them and used the invoke_signed directly in this PR #3.

Do you want to fix the formatting issue so we can merge this? I can then rebase my PR so we have the updated values for all programs.

@billythedummy
Copy link
Copy Markdown
Contributor Author

Apologies for the markdown reformatting, could you please share your formatter's settings so that i can sync with it? Thank you.

Do you have format-on-save enabled? If so, it's probably easier for you to do it then merge like the other PR if it isn't too much of a hassle. Otherwise, could you share your formatter's settings so that I can use it?

@febo
Copy link
Copy Markdown
Owner

febo commented May 2, 2025

Apologies for the markdown reformatting, could you please share your formatter's settings so that i can sync with it? Thank you.

Do you have format-on-save enabled? If so, it's probably easier for you to do it then merge like the other PR if it isn't too much of a hassle. Otherwise, could you share your formatter's settings so that I can use it?

Don't worry about the formatting, it was manual. 😅

Looks great!

@febo febo merged commit c7ba5f7 into febo:main May 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants