Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: understanding knowledge, naming page translated into Korean #762

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Nov 20, 2024

Background

We translated the understanding knowledge, naming page.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Nov 20, 2024

👷 Deploy request for pr-fsd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a321630

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Jan 27, 2025

기존에 PR 반영 했던 부분에서 전체적으로 복잡한 설명과 중복된 내용이 많아서, 핵심 내용 위주로 간결하게 재구성했습니다.

@illright
Copy link
Member

@Gaic4o could you resolve the conflicts here please?

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Jan 28, 2025

@illright I edited it. thank you

@Gaic4o Gaic4o requested a review from illright January 30, 2025 02:40
@illright illright merged commit 78115d2 into feature-sliced:master Feb 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants