Repository navigation
Fail when a model change has no migration - #20
Merged
Merged
Conversation
The bUnit tests build their schema from the model, so a model change without a migration passed every test and only failed at startup.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bUnit tests create their schema from the model (
EnsureCreated()), so a model change committed without amigration passed every test and only failed at startup in the cluster.
Changes
New test
MigrationsTests.Model_changes_all_have_a_migration:db.Database.HasPendingModelChanges()must befalse. Its failure message says how to add the migration.It's a plain unit test, not a SQL Server test: the check compares the model with the last migration's snapshot
and never opens the database. The context is configured with
UseSqlServer(connection string never used), so theSQL Server model is compared, and the test needs no Docker.
Testing
Passes on main. With a property added to
Workoutand no migration, it fails with the message.