Skip to content

Implement Get note by ID in the API#470

Closed
malev wants to merge 1 commit intofccview:mainfrom
malev:feature/api-get-note-by-id
Closed

Implement Get note by ID in the API#470
malev wants to merge 1 commit intofccview:mainfrom
malev:feature/api-get-note-by-id

Conversation

@malev
Copy link
Copy Markdown

@malev malev commented Mar 25, 2026

GET /api/notes/:id return the given note

Supports 404 and 401

Closes #451

GET /api/notes/:id return the given note

Supports 404 and 401
@malev malev marked this pull request as ready for review March 25, 2026 05:18
@fccview
Copy link
Copy Markdown
Owner

fccview commented Mar 26, 2026

Hey!

I'm sorry this has actually already been done and ready to be merged in the other open merge request (I did label it as ready for deployment on the issue)

Annoyingly, because it's much nicer to get contributors, but if I merge this we'll get conflicts

I'll see how bad it is on my end and if it's easy enough to merge I'll keep your version so you get added to the contributors list :)

Just need a bit of time, sorry, still in hospital

@malev
Copy link
Copy Markdown
Author

malev commented Mar 26, 2026

thank you so much!

@fccview
Copy link
Copy Markdown
Owner

fccview commented Apr 9, 2026

Sorry there were too many conflicts, this was actually already implemented in #484 before your mr was created and whilst I'd love to have you as contributor it's a lot of work to go through and fix all conflicts because this pr was pointing at the wrong branch.

Please feel free to contribute again on the future but make sure to point to the right branch so you get the latest codebase so this won't happen again ❤️

@fccview fccview closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: I should be able to retrieve a specific note with and ID via the API (GET)

2 participants