Optimized difficulty toggle to work on very long lists (1000+ problems) - #3
Open
henryjw wants to merge 1 commit into
Open
Optimized difficulty toggle to work on very long lists (1000+ problems)#3henryjw wants to merge 1 commit into
henryjw wants to merge 1 commit into
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a problem with most lists, but there are some like Google's all time questions list (1700+) problems and (more commonly) the list of all problems on LeetCode (3500+ problems). Basically, the extension would hang when trying to process so many items. With this change, it now takes less than a second or two to process such lists.
The batching implementation works on all pages. But feel free to make any changes if needed.
Before
After
