fix(manifest): allow missing safe diagnostic flags#95
Merged
Conversation
Add missing read-only flags that were causing command rejections: - systemctl list-units: allow --failed (filters to failed units) - journalctl: allow -p/--priority (filter by syslog priority) and --no-pager (essential for non-interactive use) These flags were identified from production logs where legitimate diagnostic commands were being rejected. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Add commonly-used read-only flags that were rejected in production: - journalctl: -t/--identifier, -k/--dmesg, -b, -o/--output, -r/--reverse, -x/--catalog - ps: --sort, -p, -u, -C, --no-headers - top: -o, -p, -u, -w All flags are read-only/diagnostic and safe to allow. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
journalctl,ps, andtopmanifests to prevent future rejectionsFlags added
journalctl:
-t/--identifier,-k/--dmesg,-b,-o/--output,-r/--reverse,-x/--catalog,-p/--priority,--no-pagersystemctl list-units:
--failedps:
--sort,-p,-u,-C,--no-headerstop:
-o,-p,-u,-wRejected commands that prompted this fix
systemctl list-units --failed--failedjournalctl -p err --since "1 hour ago" --no-pager-p,--no-pagerjournalctl -t ...-tps -eo pid,%cpu --sort=-%cpu--sorttop -b -n 1 -o %CPU-oTest plan
go build ./...)-f/--followfor journalctl) still reject🤖 Generated with Claude Code