Skip to content

Fix socket-path tests and add control socket API#89

Merged
jonchun merged 5 commits intomainfrom
fix/test-socket-paths-and-lint
Feb 28, 2026
Merged

Fix socket-path tests and add control socket API#89
jonchun merged 5 commits intomainfrom
fix/test-socket-paths-and-lint

Conversation

@jonchun
Copy link
Copy Markdown
Collaborator

@jonchun jonchun commented Feb 18, 2026

Summary

  • keep unix socket test paths short on macOS and resolve staticcheck nil warnings
  • add a control package that exposes a JSON-over-unix-socket API (connect, disconnect, status)
  • wire control socket startup into RunStdio via SHELLGUARD_CONTROL_SOCKET
  • add env-based auto-connect parsing fields in config and expose ConnectedHostsSnapshot on core
  • update server tests to use the exported snapshot method

Testing

  • GOCACHE=/tmp/go-build go test ./server -count=1
  • GOCACHE=/tmp/go-build sh -c 'go list ./... | rg -v "/ssh$" | xargs go test -count=1'
  • full make test in this sandbox still fails in ./ssh because unix-socket agent bind operations are not permitted

Covers local heuristic-based secrets protection with two phases:
pre-execution path checking to block access to sensitive files, and
post-execution output scrubbing to redact known secret patterns from
stdout/stderr before returning to the LLM.
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@jonchun jonchun changed the title Fix test socket path length and staticcheck warnings Fix socket-path tests and add control socket API Feb 28, 2026
@jonchun jonchun merged commit 4b46c0a into main Feb 28, 2026
2 checks passed
@jonchun jonchun deleted the fix/test-socket-paths-and-lint branch February 28, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant