Skip to content

util: catch exceptions trying to execute system commands #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

util: catch exceptions trying to execute system commands #2537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
719369b
util: catch exceptions trying to execute system commands
bhcleek Oct 6, 2019
db8389c
util: provide some useful output strings
bhcleek Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions autoload/go/util.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,17 +193,21 @@ function! go#util#Exec(cmd, ...) abort
" CheckBinPath will show a warning for us.
let l:bin = go#path#CheckBinPath(l:bin)
if empty(l:bin)
return ['', 1]
return ['command not found', 1]
endif

" Finally execute the command using the full, resolved path. Do not pass the
" unmodified command as the correct program might not exist in $PATH.
return call('s:exec', [[l:bin] + a:cmd[1:]] + a:000)
try
return call('s:exec', [[l:bin] + a:cmd[1:]] + a:000)
catch
return [v:exception, 1]
endtry
endfunction

function! go#util#ExecInDir(cmd, ...) abort
if !isdirectory(expand("%:p:h"))
return ['', 1]
return ['not a directory', 1]
endif

let cd = exists('*haslocaldir') && haslocaldir() ? 'lcd ' : 'cd '
Expand Down