Skip to content

fix: Set bad exit code on error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukasHechenberger
Copy link

Otherwise CircleCI does not fail on bad commit messages

Otherwise circleci does not fail on bad commit messages
@alexframe
Copy link

alexframe commented Apr 11, 2019

@LukasHechenberger I came here just because of this issue, seems the plugin is useless without your change.

In the mean time you can achieve pretty much the same result (without this dependency) by doing the following in your .circleci/config.yml

      - run:
          name: Commit lint
          command: ./node_modules/.bin/commitlint --from origin/master --to ${CIRCLE_SHA1}

I hope this gets merged though 🤞

@LukasHechenberger
Copy link
Author

You can also use my fork in the meantime, it's available on npm as @ls-age/commitlint-circle.

@rigobcastro
Copy link

@LukasHechenberger Thanks for this solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants