Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kvstore): improve key deletion performance #892

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Integralist
Copy link
Collaborator

WIP.

I don't have capacity to see this work through to completion but hopefully it's enough to get you started.

Needs integration tests to be validated (e.g. create an actual kv store with entries and make sure the keys are deleted successfully).

@Integralist Integralist force-pushed the integralist/kvstore-delete branch from 5f750d1 to 60e0f55 Compare November 1, 2024 11:31
@kpfleming
Copy link
Contributor

I had a thought this morning: rather than duplicating this functionality here and in the CLI, we could just put it into go-fastly.

@Integralist
Copy link
Collaborator Author

Yup. Great point 👍🏻 Agreed.

@Integralist
Copy link
Collaborator Author

That said, there has been concerns mentioned before about custom logic like this going into go-fastly if the intention is to have something like fastly-go be the primary API client (as we'd then have to build this behaviour into someone else's templates as part of the code generation process).

@kpfleming
Copy link
Contributor

Understood, although given the state of fastly-go and the other generated clients today, that won't be a concern for quite some time.

This could also be some leverage for us to push back on the KV Store team to just add this an actual API endpoint :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants