Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tls_mutual_authentication): Ensure that 'enforced' property does not revert to default during changes. #890

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

kpfleming
Copy link
Contributor

@kpfleming kpfleming commented Oct 22, 2024

Ensure that 'enforced' property does not revert to default during changes.

If the 'enforced' property was already set to true in the configuration, and the name (or certificate bundle) of an MTLS authentication resource was changed, the 'enforced' property would revert to 'false'.

…not revert to default during changes.

If the 'enforced' property was already set to true in the
configuration, and the name (or certificate bundle) of an MTLS
authentication resource was changed, the 'enforced' property would
revert to 'false'.
@kpfleming
Copy link
Contributor Author

kpfleming commented Oct 22, 2024

make testacc TESTARGS='-run=TestAccFastlyMTLS' passes with these changes (it failed after the new test case was added but before the code was changed to always specify the enforced value).

@kpfleming kpfleming marked this pull request as ready for review October 22, 2024 17:17
@kpfleming
Copy link
Contributor Author

There are two commits in this PR, one which just makes it easier to build and test with 'named' Go binary versions. Review will be easier if the commits are reviewed separately.

Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kpfleming kpfleming merged commit de01fe6 into fastly:main Oct 28, 2024
9 checks passed
@kpfleming kpfleming deleted the cdtool-938 branch October 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants