connmgr: add ability to respond via router instead of pub #48078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarneges
force-pushed
the
jkarneges/allow-router-resp
branch
from
61d214c to
301c8a8
Compare
jkarneges
commented
Oct 3, 2024
| @@ -420,46 +425,30 @@ impl Connections { | |||
|
|
|||
| assert!(count <= zhttppacket::IDS_MAX); | |||
|
|
|||
| let zreq = zhttppacket::Request { | |||
| let zresp = zhttppacket::Response { | |||
There was a problem hiding this comment.
This was supposed to be a response packet rather than a request packet. We've simply been lucky that they serialize the same.
madeline-pratt
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48073, this completes the implementation in connmgr for sending response data via router. After this, proxy will need to be updated to support receiving response data this way.
Notably, the following changes are made:
make_zhttp_response()is reworked to support producing either PUB-style or ROUTER-style message formats, returning aSome(addr)in the case of the latter. It is also made public and shared across modules to reduce code duplication.StreamSharedDatastruct. Whenever response data needs to be sent, this flag can be checked to decide whether to respond via ROUTER or not.Nonefor the address, the value is specified asSomeorNonedepending on whether router-resp was requested.The rest of the changes are mainly tests.