Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove configure script and base qmake project #47803

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jkarneges
Copy link
Member

@jkarneges jkarneges commented Nov 28, 2023

This removes the configure script and qconf modules, and replaces the base qmake project with a hand-written makefile. Support for conf.pri is removed and any configuration must be done via environment variables. The project can now be built out of the box simply by running make (no need to run qmake first).

Copy link
Contributor

@sima-fastly sima-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so neat! thanks 🎖️

Copy link
Contributor

@sima-fastly sima-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add these makefiles to .gitignore?
Screenshot 2023-11-27 at 8 33 53 PM

@jkarneges jkarneges merged commit 024c9fe into main Nov 28, 2023
1 check passed
@jkarneges jkarneges deleted the jkarneges/remove-configure branch November 28, 2023 06:10
@jkarneges
Copy link
Member Author

Ah, those makefiles are old, you can delete them. They are now generated in the target dir which is ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants