convert rust build from qmake project to plain makefile #47800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the src/rust/rust.pro and src/src.pro qmake projects into a simple hand-written makefile that forwards to cargo commands. Setting environment variable
RELEASE=1can be used to build in release mode. By default, the build is in debug mode.The qmake project at the root is a basic subdirs project that runs make in src and postbuild, such that running make at the root will run in make in src which will run cargo build. This means make is now essentially an alias to cargo build, as there are no meaningful intermediate steps. If you don't need to run the postbuild steps (i.e. you only need to test compilation or run unit tests, but don't need to actually run pushpin) then using cargo commands directly should be sufficient.