Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Qt Signal Slot with Boost Signals2 #47779

Merged
merged 25 commits into from
Nov 22, 2023
Merged

Replacing Qt Signal Slot with Boost Signals2 #47779

merged 25 commits into from
Nov 22, 2023

Conversation

sima-fastly
Copy link
Contributor

@sima-fastly sima-fastly commented Nov 10, 2023

This is the first PR in a series of PRs to replace Qt signal & slot system with Boost Signals2.

In this PR we are replacing qt signal slots in the very top layer of all services quit & hup signals.

Tested manually
Screenshot 2023-11-14 at 5 32 26 AM
Screenshot 2023-11-14 at 5 34 34 AM
Screenshot 2023-11-14 at 5 34 42 AM

@sima-fastly sima-fastly self-assigned this Nov 10, 2023
@sima-fastly sima-fastly changed the title Sima/qt boost Replacing Qt Signal Slot with Boost Signals2 Nov 10, 2023
@sima-fastly sima-fastly marked this pull request as ready for review November 13, 2023 20:42
@sima-fastly sima-fastly force-pushed the sima/qt-boost branch 7 times, most recently from c9e6f99 to b9d25da Compare November 14, 2023 12:57
Copy link
Member

@jkarneges jkarneges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the Q_OBJECT macro from class definitions as well as the QObject inheritance.

qcm/boost.qcm Outdated Show resolved Hide resolved
src/cpp/handler/handlerapp.cpp Outdated Show resolved Hide resolved
src/cpp/handler/handlerapp.cpp Outdated Show resolved Hide resolved
src/cpp/handler/handlerapp.h Outdated Show resolved Hide resolved
src/cpp/handler/handlermain.cpp Show resolved Hide resolved
src/cpp/proxy/main.cpp Outdated Show resolved Hide resolved
@sima-fastly
Copy link
Contributor Author

We should also remove the Q_OBJECT macro from class definitions as well as the QObject inheritance.

I agree, that can be done after Qt signal/slot cleanup?

@jkarneges
Copy link
Member

We should also remove the Q_OBJECT macro from class definitions as well as the QObject inheritance.

I agree, that can be done after Qt signal/slot cleanup?

That's fine but do we know if such removal is possible? It only makes sense to move to boost if we can actually get off of QObject. It would be good to try this locally at least, and then the change could go in a later PR.

@sima-fastly
Copy link
Contributor Author

We should also remove the Q_OBJECT macro from class definitions as well as the QObject inheritance.

I agree, that can be done after Qt signal/slot cleanup?

That's fine but do we know if such removal is possible? It only makes sense to move to boost if we can actually get off of QObject. It would be good to try this locally at least, and then the change could go in a later PR.

from what I understand so far, I am fairly certain it is possible but I am gonna have to peel back layers one by one which will take weeks.

@sima-fastly
Copy link
Contributor Author

We should also remove the Q_OBJECT macro from class definitions as well as the QObject inheritance.

I agree, that can be done after Qt signal/slot cleanup?

That's fine but do we know if such removal is possible? It only makes sense to move to boost if we can actually get off of QObject. It would be good to try this locally at least, and then the change could go in a later PR.

from what I understand so far, I am fairly certain it is possible but I am gonna have to peel back layers one by one which will take weeks.

thanks for this suggestion, QObject & Q_Object are removed from services' main fn

src/cpp/handler/handlerapp.cpp Outdated Show resolved Hide resolved
src/cpp/handler/handlermain.cpp Outdated Show resolved Hide resolved
src/cpp/handler/handlermain.cpp Show resolved Hide resolved
@sima-fastly sima-fastly merged commit 181a98a into main Nov 22, 2023
1 check passed
@sima-fastly sima-fastly deleted the sima/qt-boost branch November 22, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants