-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing Qt Signal Slot with Boost Signals2 #47779
Conversation
c9e6f99
to
b9d25da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove the Q_OBJECT
macro from class definitions as well as the QObject
inheritance.
I agree, that can be done after Qt signal/slot cleanup? |
That's fine but do we know if such removal is possible? It only makes sense to move to boost if we can actually get off of QObject. It would be good to try this locally at least, and then the change could go in a later PR. |
f854774
to
d41f1f8
Compare
from what I understand so far, I am fairly certain it is possible but I am gonna have to peel back layers one by one which will take weeks. |
thanks for this suggestion, QObject & Q_Object are removed from services' main fn |
170d530
to
a8c6fe1
Compare
f27c3c1
to
7c35c5a
Compare
This reverts commit b65ef81.
7c35c5a
to
4e123a3
Compare
6e3983f
to
55419be
Compare
55419be
to
8b78902
Compare
638f5f1
to
226982d
Compare
This is the first PR in a series of PRs to replace Qt signal & slot system with Boost Signals2.
In this PR we are replacing qt signal slots in the very top layer of all services quit & hup signals.
Tested manually