convert all programs to rust programs calling mains from cpp lib #47771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarneges
force-pushed
the
jkarneges/rust-bins
branch
from
3cfa8a4 to
5ef1971
Compare
jkarneges
force-pushed
the
jkarneges/rust-bins
branch
from
5ef1971 to
da4ca41
Compare
sima-fastly
reviewed
Nov 7, 2023
| pushpin_bin.commands = cp -a $$target_dir/pushpin $$root_dir/pushpin | ||
| m2adapter_bin.target = $$bin_dir/m2adapter | ||
| m2adapter_bin.depends = m2adapter_build | ||
| m2adapter_bin.commands = mkdir -p $$bin_dir && cp -a $$target_dir/m2adapter $$bin_dir/m2adapter |
There was a problem hiding this comment.
do we need mkdir -p $$bin_dir cmd to be repeated for these bins?
There was a problem hiding this comment.
Sort of. The bin dir isn't part of the repo and is created on demand. Since it is possible for make to run individual targets or to run these targets in different orders, they all try to make the bin dir.
There was a problem hiding this comment.
in that case do we need to add the mkdir to runner_legacy_bin.commands & runner_bin.commands ?
There was a problem hiding this comment.
ah, the runner(s) go in the root dir not the bin dir, so they don't need it.
sima-fastly
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably this changes the build order. Previously, the Rust code was built first (lib and programs) followed by all the C++ code which could use the Rust lib as needed. With this change, the C++ lib is built first, followed by the Rust code which uses the C++ lib as needed, followed by the C++ tests which use both the C++ lib and Rust lib as needed.