Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename src/corelib to src/cpp #47767

Merged
merged 1 commit into from
Nov 3, 2023
Merged

rename src/corelib to src/cpp #47767

merged 1 commit into from
Nov 3, 2023

Conversation

jkarneges
Copy link
Member

this is preparation for consolidating all C++ code into src/cpp

sima-fastly
sima-fastly reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@sima-fastly sima-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some refs to corelib in .gitignore and package.sh

@jkarneges
rename src/corelib to src/cpp
d79f8c8 
this is preparation for consolidating all C++ code into src/cpp
@jkarneges
Copy link
Member Author

Good catch. Fixed.

sima-fastly
sima-fastly approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@sima-fastly sima-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jkarneges jkarneges merged commit d1801b8 into main Nov 3, 2023
@jkarneges jkarneges deleted the jkarneges/cpplib branch November 3, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sima-fastly sima-fastly sima-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkarneges @sima-fastly